Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/rds_role_association: wait for cluster/instance to be available #39457

Merged
merged 6 commits into from
Sep 24, 2024
Merged

r/rds_role_association: wait for cluster/instance to be available #39457

merged 6 commits into from
Sep 24, 2024

Conversation

johnsonaj
Copy link
Contributor

Description

Role association will intermittently fail to apply if the cluster/instance is not in an available state.

Relations

References

Output from Acceptance Testing

% make testacc TESTARGS="-run=TestAccRDSInstanceRoleAssociation_\|TestAccRDSClusterRoleAssociation_" PKG=rds

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.7 test ./internal/service/rds/... -v -count 1 -parallel 20  -run=TestAccRDSInstanceRoleAssociation_\|TestAccRDSClusterRoleAssociation_ -timeout 360m
--- PASS: TestAccRDSClusterRoleAssociation_Disappears_cluster (176.35s)
--- PASS: TestAccRDSClusterRoleAssociation_disappears (197.03s)
--- PASS: TestAccRDSClusterRoleAssociation_basic (199.32s)
--- PASS: TestAccRDSClusterRoleAssociation_Disappears_role (207.08s)
--- PASS: TestAccRDSInstanceRoleAssociation_basic (1007.08s)
--- PASS: TestAccRDSInstanceRoleAssociation_disappears (1013.26s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	1019.897s

@johnsonaj johnsonaj requested a review from a team as a code owner September 23, 2024 21:35
@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/rds Issues and PRs that pertain to the rds service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Sep 23, 2024
@johnsonaj johnsonaj added the bug Addresses a defect in current functionality. label Sep 23, 2024
@jar-b jar-b self-assigned this Sep 24, 2024
jar-b
jar-b approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc PKG=rds TESTS="TestAccRDSInstanceRoleAssociation_|TestAccRDSClusterRoleAssociation_"
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.7 test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSInstanceRoleAssociation_|TestAccRDSClusterRoleAssociation_'  -timeout 360m

--- PASS: TestAccRDSClusterRoleAssociation_Disappears_cluster (179.30s)
--- PASS: TestAccRDSClusterRoleAssociation_Disappears_role (239.80s)
--- PASS: TestAccRDSClusterRoleAssociation_disappears (240.11s)
--- PASS: TestAccRDSClusterRoleAssociation_basic (240.95s)
--- PASS: TestAccRDSInstanceRoleAssociation_basic (996.34s)
--- PASS: TestAccRDSInstanceRoleAssociation_disappears (1054.32s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/rds        1061.137s

@johnsonaj johnsonaj merged commit 61692a0 into main Sep 24, 2024
45 checks passed
@johnsonaj johnsonaj deleted the b-rds_role_association branch September 24, 2024 14:22
@github-actions github-actions bot added this to the v5.69.0 milestone Sep 24, 2024
terraform-aws-provider bot pushed a commit that referenced this pull request Sep 24, 2024
Update CHANGELOG.md for #39457
7c50add
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.69.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 26, 2024
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jar-b jar-b jar-b approved these changes

Assignees

@jar-b jar-b

Labels
bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. service/rds Issues and PRs that pertain to the rds service.
Projects
None yet
Milestone
v5.69.0
Development

Successfully merging this pull request may close these issues.
2 participants
@johnsonaj @jar-b